BIND 10 #3183: perfdhcp: Add support to renew prefixes and measure server response rate

[BIND 10 Development]

#3183: perfdhcp: Add support to renew prefixes and measure server response rate
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  high          |  reviewing
           Component:  perfdhcp      |                    Milestone:
            Keywords:                |  Sprint-DHCP-20131016
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by tmark):

 Replying to [comment:5 marcin]:

 > > ----------------------------------------------
 > >
 > > packet_storage_unittest.cc
 > >
 > > General comment, there are no tests yet for Pkt4.
 >
 > This is true but the class is Packet type agnostic. There are no methods
 which would call Pkt4 or Pkt6 methods. It just holds objects. It could
 actually hold any object.

 Perhaps a general @todo at the top of the file that states pkt4 tests
 should be added when pkt4 support is added.

 > >
 > > test_control.cc
 > >
 > > General, there is a fair amount of complexity in clearing out the
 renewal
 > > "cache".  An alternative would be not create more if they are not
 needed.
 > > Perhaps determine a cap at runtime based on the rate(s) and if the cap
 is
 > > reached stop adding new ones?  Seems like it would be faster and
 easier to
 > > stop adding unless you until you  more than to create too many and
 delete them
 > > periodically.
 >
 > I will rethink that when I will be implementing releases. But In general
 I concur with that. It would be easier to stop adding packets, rather than
 clear.

 Fair enough.



 Other than the @todo mentioned above, please merge in your changes.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3183#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development