BIND 10 #2857: memory manager initial exchanges
BIND 10 Development
do-not-reply at isc.org
Wed Sep 4 12:59:51 UTC 2013
#2857: memory manager initial exchanges
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | vorner
Priority: medium | Status:
Component: shmem | reviewing
manager | Milestone:
Keywords: | Sprint-20130917
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 5 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| shared memory data source
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => vorner
Comment:
Hi Michal
Replying to [comment:9 vorner]:
> > * Is it not possible to setup and use a real `DataSrcInfo` for
testing?
>
> It would be possible, yes. But the amount of work would be significantly
higher than this mock, because the constructor insists on examining the
config so I'd have to take care to construct a correct config. And, in the
end, the code would take the clients_map only, which is just a dict. So it
sounds to me like wasted effort.
I think you can reuse some of the code at the end of the builder
unittests.. it does something similar. A real testcase means that the next
developer who builds on top of this work knows for certain it would work
with a real `DataSrcInfo`, and also have a usage example esp. as our
design keeps changing.
The branch seems ready for merge now. `make check` also passes again.
--
Ticket URL: <http://bind10.isc.org/ticket/2857#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list