BIND 10 #3107: [kean] ./configure report versions of dependencies

BIND 10 Development do-not-reply at isc.org
Tue Sep 10 11:19:35 UTC 2013


#3107: [kean] ./configure report versions of dependencies
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  kean
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  build system  |                    Milestone:
            Keywords:                |  Sprint-20130917
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => kean


Comment:

 Hi Kean

 Here are my review comments:

 * Include versions of the following: C++ compiler, Valgrind (if found),
   cppcheck (if found), sed. Different versions of these have different
   behaviors and we often look for their version information.

 * In your code, please include the angle brackets syntax of `#include`,
   i.e.:

 {{{
 -#include "log4cplus/version.h"
 +#include <log4cplus/version.h>
 }}}

   This is in our CodingGuidelines. (We had a discussion of both styles a
   few months ago and are aware of the differences.)

 * Will the `conftest.cpp` pre-processing go well if dependencies like
   log4cplus are installed in a non-standard path?

 * Instead of this `sed` stuff, I suggest compiling `conftest.cpp` into a
   program which prints the component's version. Assign this output to a
   environment variable. This is so that even if the syntax of macros
   like `LOG4CPLUS_VERSION_STR` were to change, there would be no output
   processing to fix.

 * What about the cases where `botan-config`, `gtest-config`, etc. are
   not available?

 * Please ask `jreed` to put this branch to test on the various builders
   and check if each builder reports the versions correctly.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3107#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list