BIND 10 #3161: Fix clang-analyzer failures

[BIND 10 Development]

#3161: Fix clang-analyzer failures
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  Next-Sprint-
                   Priority:         |  Proposed
  medium                             |              Keywords:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
               CVSS Scoring:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 In yesterday's team meeting, we decided to create this ticket about
 `clang-analyzer` static analysis failures and fix them so that we can use
 future reports.

 This ticket should get rid of all failures and cause a clean report to be
 generated without defects. If there are false positives, or if we don't
 want to fix code according to the report, please add appropriate
 annotations to inhibit these reports from being generated.

-- 
Ticket URL: <https://bind10.isc.org/ticket/3161>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development