BIND 10 #3112: boost::optional failure on Debian i686

BIND 10 Development do-not-reply at isc.org
Mon Sep 16 11:59:37 UTC 2013


#3112: boost::optional failure on Debian i686
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  high          |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130917
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 First, I tried to reproduce on a debian I installed into a virtual
 machine. I didn't get the error, so I'm not sure it helped, but I guess
 you tried on that machine.

 The other thing, this comment with two copy constructors:
 {{{#!c++
     /// \brief Copy constructor.
     ///
     /// This constructor never throws an exception.
 }}}

 This could lead people to believe that this bit of code could never throw:
 {{{#!c++
 RRTTL *ttl = new RRTTL(other_ttl);
 }}}

 This is not true (it can throw std::bad_alloc), even though the comment is
 not a lie strictly speaking, because the thing that throws is not the
 constructor itself. May I suggest either removing the comment about
 exceptions completely or restating it somehow?

 Other than that, I think it can be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3112#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list