BIND 10 #3169: Replace use of char* with void* cast in buffer bindings in dhcspsrv/mysql_lease_mgr.cc

[BIND 10 Development]

#3169: Replace use of char* with void* cast in buffer bindings in
dhcspsrv/mysql_lease_mgr.cc
-------------------------------------+-------------------------------------
                   Reporter:  tmark  |                 Owner:
                       Type:         |                Status:  new
  defect                             |             Milestone:  DHCP
                   Priority:  very   |  Outstanding Tasks
  low                                |              Keywords:
                  Component:         |             Sensitive:  0
  dhcpdb                             |           Sub-Project:  DHCP
               CVSS Scoring:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 While reviewing trac# 3147, Stephen had the following comment:
 {{{
 I note that in all cases, when the MYSQL_BIND "buffer" variable is
 assigned, the rvalue is cast to "char*".  I'm not certain why I did that
 (I wrote the original code); looking at the
 [http://dev.mysql.com/doc/refman/5.5/en/c-api-prepared-statement-data-
 structures.html MySQl documentation] and the definition of MYSQL_BIND in
 mysql.h, the "buffer" variable is a "void*".  There is no need to change,
 as the variable is automatically cast to the correct type, but maybe
 create a ticket to correct this in the code?
 }}}

 Investigate if casting to a void* would be the more proper approach.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3169>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development