BIND 10 #3113: Hooks unit-tests fail when --enable-static-link is used

BIND 10 Development do-not-reply at isc.org
Wed Sep 25 14:10:02 UTC 2013


#3113: Hooks unit-tests fail when --enable-static-link is used
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130918
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => stephen


Comment:

 I tested this under OS-x and Fedora 19, using both dynamic and static
 linking and it works.

 One minor suggestion to code comments:

 In hooks.h, !hooksStaticLinkInit is prefaced with this:

 " This function - to be called by the user library code in its load()
 function
 when running against a statically linked BIND 10 ..."

 The commentary should be a bit more explicit and say something like "it
 MUST BE CALLED by..."  and perhapsinclude a description of what ill will
 befall them otherwise. Maybe an @warning tag for doxygen?   I just think
 it might be a bit more prominently pointed out.

 I will leave that to your judgement.  I do not need to see the ticket
 again.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3113#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list