BIND 10 #3151: PD: Configuration parsers much be able to parse PD configuration
BIND 10 Development
do-not-reply at isc.org
Fri Sep 27 12:08:34 UTC 2013
#3151: PD: Configuration parsers much be able to parse PD configuration
-------------------------------------+-------------------------------------
Reporter: tomek | Owner: tmark
Type: enhancement | Status:
Priority: medium | closed
Component: dhcpconf | Milestone:
Keywords: | Sprint-DHCP-20130918
Sensitive: 0 | Resolution:
Sub-Project: DHCP | complete
Estimated Difficulty: 0 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by tmark):
* status: reviewing => closed
* resolution: => complete
Comment:
Replying to [comment:7 tomek]:
> Replying to [comment:6 tmark]:
> > It would be useful, but why start a trend? I added the class comment
(thought I had done that...) which includes an example.
> It's almost good, but I think the initial triple curly braces are not
necessary.
Oops. I meant to use @code @endcode. Corrected.
> > > '''src/lib/dhcpsrv/tests/test_libraries.h'''
> > > You modified its content and replaced /home/thomson/... with
> > > /Users/tmark/... I'm not sure if I like that change :)
> > > In fact, why they test_libraries.h file is in the repo at all?
> >
> > It should not be there at all. I pulled a fresh copy of trac3151 and
it isn't there, nor will git let me "rm" it.
>
> thomson at billabong:~/devel/bind10$ git status
> # On branch trac3151
> # Changes not staged for commit:
> # (use "git add <file>..." to update what will be committed)
> # (use "git checkout -- <file>..." to discard changes in working
directory)
> #
> # modified: src/lib/dhcpsrv/tests/test_libraries.h
> {{{
> git blame src/lib/dhcpsrv/tests/test_libraries.h
> }}}
> shows that it was added in commit a26a75c9 (by me) and later updated in
commit f67708b1 (by you).
>
> I don't understand why it is on my trac3151 branch, but not on yours.
That's odd.
It helps when one looks in the proper directory. I was correct in that
there is no such file in src/bin/dhcp6/tests. You are correct in that
there is such a file in src/lib/dhcpsrv/tests. I have removed the
offending file.
Changes merged with git 79a22be33825bafa1a0cdfa24d5cb751ab1ae2d3
Added !ChangeLog entry 681.
--
Ticket URL: <http://bind10.isc.org/ticket/3151#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list