BIND 10 #1894: use labelsequence in findNSEC3

BIND 10 Development do-not-reply at isc.org
Tue Feb 4 04:23:57 UTC 2014


#1894: use labelsequence in findNSEC3
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  enhancement   |  pselkirk
            Priority:  high          |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  bind10-1.2-release-freeze
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => pselkirk


Comment:

 Hi Paul

 Replying to [comment:7 pselkirk]:
 > This seems to work. However, it could be yet more efficient if we didn't
 have to repeatedly copy and downcase the name - e.g. if we could hand
 {{{calculate()}}} a {{{Name}}} or {{{LabelSequence}}} that was already
 downcased. But that's a minor optimization, and probably out of scope for
 this ticket.

 This is a good idea. I've created ticket #3321 for it.

 > Of much greater concern is that the {{{Name::split()}}} technique is
 still used in {{{DatabaseClient::Finder::findNSEC3()}}}, and the ticket
 description explicitly says "for db and mem backends".

 Good catch. I forgot to fix the database backend. It's done now. Please
 review.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1894#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list