BIND 10 #3301: lettuce failure in Scenario: Handle incoming notify (XFR request rejected) --- assert found != not_message, line

[BIND 10 Development]

#3301: lettuce failure in Scenario: Handle incoming notify (XFR request rejected)
--- assert found != not_message, line
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  tests         |                    Milestone:
            Keywords:                |  bind10-1.2-release-freeze
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => muks


Comment:

 In Scenario: Handle incoming notify (XFR request rejected in IPv4) I get a
 new failure that wasn't there before:
 {{{
 And wait for bind10 stderr message ZONEMGR_STARTED
 # features/terrain/steps.py:34
     Traceback (most recent call last):
       File "/usr/lib/python2.7/site-packages/lettuce/core.py", line 143,
 in __call__
         ret = self.function(self.step, *args, **kw)
       File
 "/home/kean/isc/bind10/tests/lettuce/features/terrain/steps.py", line 54,
 in wait_for_stderr_message
         (found, line) = world.processes.wait_for_stderr_str(process_name,
 strings, new, int(times))
       File
 "/home/kean/isc/bind10/tests/lettuce/features/terrain/terrain.py", line
 389, in wait_for_stderr_str
         matches)
       File
 "/home/kean/isc/bind10/tests/lettuce/features/terrain/terrain.py", line
 291, in wait_for_stderr_str
         strings, only_new, matches)
       File
 "/home/kean/isc/bind10/tests/lettuce/features/terrain/terrain.py", line
 276, in _wait_for_output_str
         assert False, "Timeout waiting for process output: " +
 str(strings)
     AssertionError: Timeout waiting for process output:
 [u'ZONEMGR_STARTED']
 }}}

 I then re-ran the tests 3 times and it didn't appear. It also didn't
 appear when I run just that test in isolation. So it must have been some
 kind of anomaly.

 I noticed the removal of the following comment:
 {{{
     # From this point we can't reliably 'wait for new' because the
 ordering
     # of logs from different processes is unpredictable.  But these
     # should be okay in this case.
 }}}

 and then you use "wait for new". In 2 other places a comment saying they
 cant use wait for new was also changed. However I didn't see any changes
 in the harness itself that would change the "wait for new" behaviour. Were
 those old comments simply inaccurate? Some of them look like it was just
 cut-n-paste so they may well have been. If that is the case then this
 looks fine, please go ahead and merge and close.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3301#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development