BIND 10 #2185: RR type implementation: TLSA

[BIND 10 Development]

#2185: RR type implementation: TLSA
-------------------------------------+-------------------------------------
            Reporter:  shane         |                        Owner:  muks
                Type:  enhancement   |                       Status:
            Priority:  high          |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  bind10-1.2-release-freeze
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * owner:  UnAssigned => muks


Comment:

 My intent wasn't to cause more work, just to point out that {{{auto_ptr}}}
 has been deprecated, so this code might not work with some future version
 of the compiler.

 The new {{{RdataPimplHolder}}} class is an interesting experiment, and
 probably not heavier-weight than {{{auto_ptr}}}, but it's more code to
 test and maintain (and to update the 7 other {{{Rdata}}} classes that use
 {{{auto_ptr}}}), so I would tend to resist it on those grounds.

 Also, it doesn't compile:
 {{{
 In file included from rdata_pimpl_holder_unittest.cc:15:0:
 ../../../../src/lib/dns/rdata_pimpl_holder.h:27:31: error: ‘NULL’ was not
 declared in this scope
      RdataPimplHolder(T* obj = NULL) :
                                ^
 ../../../../src/lib/dns/rdata_pimpl_holder.h:35:25: error: ‘NULL’ was not
 declared in this scope
      void reset(T* obj = NULL) {
                          ^
 ../../../../src/lib/dns/rdata_pimpl_holder.h: In member function ‘T*
 isc::dns::rdata::RdataPimplHolder<T>::release()’:
 ../../../../src/lib/dns/rdata_pimpl_holder.h:46:16: error: ‘NULL’ was not
 declared in this scope
          obj_ = NULL;
                 ^
 rdata_pimpl_holder_unittest.cc: In member function ‘virtual void
 {anonymous}::RdataPimplHolderTest_all_Test::TestBody()’:
 rdata_pimpl_holder_unittest.cc:39:19: error: call to ‘void
 isc::dns::rdata::RdataPimplHolder<T>::reset(T*) [with T = int]’ uses the
 default argument for parameter 1, which is not yet defined
      holder2.reset();
 }}}

 In commit 506b531, I see you now disallow empty Certificate Association
 Data, which addresses my other comment in comment:5.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2185#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development