BIND 10 #2426: support generic version of rdata::createRdata(text) in generic RDATA

[BIND 10 Development]

#2426: support generic version of rdata::createRdata(text) in generic RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  bind10-1.2-release-freeze
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  UnAssigned => muks


Comment:

 Reviewed commit 659fb323f0b7fdd279cc1c36b0f5fe6526a0994e

 '''src/lib/dns/rdata.cc'''
 constructFromLexer: some versions of cppcheck are likely to object to
 declaring rdlen without an initialization value.

 constructFromLexer: minor point - in the read loop, I'd be inclinded to
 put the ungetToken() call immediately after the test for end of file/line
 and before the break, as it's more immediately obvious what is being
 "ungot".  However I won't push this issue - where it is at the moment is
 correct. (It would be useful to have a comment as to why the end of
 file/line are being left in the read buffer.)

 constructFromLexer: If the data size is not equal to RDLENGTH, a better
 string to go into the exception would be something like "Size of unknown
 RDATA hex data doesn't match RDLENGTH".

 '''General'''
 What Jinmei's comment about "origin" relates to.  The only constructor
 that takes a "Name" as an argument ignores it.

 !ChangeLog entry template is OK.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2426#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development