BIND 10 #3322: Client classification: relay address override
BIND 10 Development
do-not-reply at isc.org
Mon Feb 24 10:15:43 UTC 2014
#3322: Client classification: relay address override
-------------------------------------+-------------------------------------
Reporter: tomek | Owner: tomek
Type: enhancement | Status:
Priority: high | reviewing
Component: dhcp | Milestone: DHCP-
Keywords: | Kea0.9-alpha
Sensitive: 0 | Resolution:
Sub-Project: DHCP | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity:
Total Hours: 13 | Medium
| Feature Depending on Ticket:
| Add Hours to Ticket: 2
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by marcin):
* hours: 8 => 2
* owner: marcin => tomek
* totalhours: 11 => 13
Comment:
Reviewed commit 97f4d442ff4afde00db47f4108212d17c89752a5
I fixed one typo in the header file, so please pull this change before
merge.
'''lib/dhcp/IfaceMgrTestConfig.cc'''
In the constructor you select the stub packet filter which remains set as
long as the unit test is being run. I think you should set a default
packet filter in the class destructor (it is being done for v4 stub) to
make sure that we don't use the stub in the subsequent tests if they don't
need it, or if they must use real sockets and interfaces.
Apart from this, your changed are good. When you fix the issue mentioned
above, please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/3322#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list