BIND 10 #3207: per-client option values (hook lib extension)

[BIND 10 Development]

#3207: per-client option values (hook lib extension)
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  closed
           Component:  dhcp          |                    Milestone:  DHCP-
            Keywords:                |  Kea1.0-alpha
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |  complete
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * status:  reviewing => closed
 * resolution:   => complete


Comment:

 Replying to [comment:7 tomek]:
 > '''libdhcp_user_chk.dox''': sring => string
 >
 > "may have the one or more of the following entries:"
 > Is it true? I thought that not having them at all is also possible. So
 that would probably be better worded as "zero or more".
 >

 Good catch, yes it is zero or more.


 > '''pkt6_send_co.cc'''
 > pkt6_send: the check in line 154 (if packet_type == DHCPV6_DECLINE) does
 not make sense. Server never sends DECLINE messages. In fact, the behavior
 should possibly be based on the query type, not response type. But it
 doesn't matter much. Let's keep the logic as simple as possible. This
 should be an example library, so let's not overengineer things.
 >
 > Please remove the @todo in 152 along with the whole check. It is ok for
 the lib to do its magic for every outgoing DHCPv6 packet.


 Done.


 >
 > ---------
 >
 > Replying to [comment:6 tmark]:
 > > In addition to the things I addressed below, I had to move the helper
 functions
 > > in pkt_send.cc out of the "extern C" linkage.  I was getting compiler
 errors
 > > informing me that functions returning C++ objects are not valid under
 C linakge.
 > > Makes sense.  I also added namespace user_chk to keep the user
 registry classes
 > > isolated into their own space.  This also groups then nicely in
 doxygen.
 > Thanks. For what it is worth, the code builds and unit-tests pass on my
 Ubuntu 13.10 x64.
 >
 > > > Please add a !ChangeLog entry.
 > >
 > > How is this? (The library was introduced in ChangeLog entry 697)
 > >
 > > {{{
 > > 7xx.    [func]  tmark
 > >
 > >     Updates the "user_check" hooks shared library with callouts for
 packet
 > >     receive and packet send.  Decision outcome now includes the lease
 or prefix
 > >     assigned.  The user registry now supports a "default" user entry.
 > >     (Trac #3207, git TBD)
 > > }}}
 >
 > Almost good, but:
 > - remove quotes
 > - user_check => user_chk
 > - please add somewhere word "example" in this changelog.
 >
 > If you agree with my suggestions, feel free to apply them and merge. I
 don't need to see this ticket again.
 >
 >


 Merged changes in with git 34fddf2e75b80d9e517a8f9c3321aa4878cda795
 Created ChangeLog entry 721 with modifications suggested

-- 
Ticket URL: <https://bind10.isc.org/ticket/3207#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development