BIND 10 #688: Make Message::hasRRset() const

BIND 10 Development do-not-reply at isc.org
Thu Jan 9 05:11:16 UTC 2014


#688: Make Message::hasRRset() const
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  very low      |                       Status:
           Component:  libdns++      |  assigned
            Keywords:                |                    Milestone:
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  0.0           |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * subproject:   => DNS
 * severity:   => N/A


Comment:

 The methods have been made `const`, but `hasRecordInAuthoritySection()`
 can't yet be removed as it does a `RRType` match only whereas
 `Message::hasRRset()` compare other fields as well.

 `hasRecordInAuthoritySection()` is old resolver code and it remains to be
 checked if testing `RRType` only in this codepath is correct code in the
 first place. I'll create a separate ticket for this.

 Up for review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/688#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list