BIND 10 #1033: need unittest for %q and log time

BIND 10 Development do-not-reply at isc.org
Mon Jan 13 08:42:15 UTC 2014


#1033: need unittest for %q and log time
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  logging       |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  0.0           |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => muks


Comment:

 Tested with log4cplus 1.1.1, the one that comes with FC19. Looks good. My
 only comment on the test is that it relies on deep knowledge of what the
 default format is. It would be better to explicitly set the layout pattern
 that you are using the regex against (which would mean you could make the
 regex a lot simpler too, it just needs to include %D{%q}), so that the
 test is insulated from changes in the future (as unlikely as that is).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1033#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list