BIND 10 #3279: DHCPv4 server should discard packets with non-matching server id

[BIND 10 Development]

#3279: DHCPv4 server should discard packets with non-matching server id
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea1.0-alpha
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  16            |                 CVSS Scoring:
         Total Hours:  10            |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  2
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => marcin
 * totalhours:  8 => 10


Comment:

 The changes are quite straight forward, I only have a few
 questions/comments:

 General question:

 * In looking at IfaceMgr::hasOpenSocket(), have you done any impact
 assessment on performance?  Granted we are not likely to have more than a
 few interfaces, with maybe one address per interface.

 * Should we consider making this check configurable?

 ----------------------------------------------------------------------------------------
 Dhcpv4Srv::acceptServerId(const Pkt4Ptr& pkt)

 You test the address list for size = 1 and return false if it is not. I'm
 assuming there is no valid case for it have more than 1 entry.  You may
 want
 to add a quick comment on this above the size test.

 -----------------------------------------------------------------------------------------

 Unit tests run with valgrind on Fedora 19.  cppcheck passes on OS-X.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3279#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development