BIND 10 #3264: Refactor d2 unit tests to use new new TransactionTest class

[BIND 10 Development]

#3264: Refactor d2 unit tests to use new new TransactionTest class
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:  DHCP-
            Keywords:                |  Kea1.0
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  5             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  2 => 1
 * owner:  marcin => tmark
 * totalhours:  4 => 5


Comment:

 Reviewed commit faf86ad3a04fc7fca0af2b9d19abba0fa1d94387

 Changes are pretty straight forward. Just some minor things...

 '''nc_trans_unittests.cc'''
 doOneExchange should be documented

 sendUPdateTimeout: I have to admit I was not familiar with the
 !''ASSERT_NO_FATAL_FAILURE!'' macro. I greped the bind10 code and the only
 occurences I found were in nc_trans_unittests.cc. Since, it is the only
 place where it is used, it would be useful to have some short explanation
 why it has to be used. I am surprised that we never used it anywhere else.

 Please check the alignment of parameters passed to ''doOneExchange''.

 Why did you check in the src/bin/d2/tests/test_data_files_config.h.in
 file?

-- 
Ticket URL: <http://bind10.isc.org/ticket/3264#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development