BIND 10 #1033: need unittest for %q and log time

BIND 10 Development do-not-reply at isc.org
Thu Jan 16 02:29:49 UTC 2014


#1033: need unittest for %q and log time
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  logging       |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  0.0           |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => muks


Comment:

 The default pattern for log messages is set in logger_manager_impl.cc to
 be {{{"%D{%Y-%m-%d %H:%M:%S.%q} %-5p [%c/%i] %m\n"}}}. That is the pattern
 your regex is testing against. If that pattern can be changed by the
 caller to be simply "%D{%q}" you can greatly reduce the complexity of the
 regex, and check for just that feature, since that is what the bug is
 about. If you can't easily change the pattern, then its fine to merge as
 is.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1033#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list