BIND 10 #3288: IfaceMgr::openSockets6 requires fixes for Linux-specific code.

BIND 10 Development do-not-reply at isc.org
Mon Jan 20 13:50:56 UTC 2014


#3288: IfaceMgr::openSockets6 requires fixes for Linux-specific code.
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea0.9-alpha
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  4             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin
 * totalhours:  3 => 4


Comment:

 I did review all changes on trac3288 up to commit
 d3f792e43cf9bacf108ad21ec58fa87d64422c7d.

 I must admit that I'm not happy with the IFACEMGR_ERROR macro, but the
 explanation
 given for it is sufficient.

 Make sure you update copyright headers in modified files.

 The code compiles cleanly on Ubuntu 13.10 x64 with g++ 4.8.1.

 It is unlikely, but somewhat possible that users could be affected by the
 failed multicast
 socket issue, hence I think this deserves a ChangeLog entry.

 Spent 1 hour on this review (Add hours to ticket stays at 1, total hours
 increased to 4).

-- 
Ticket URL: <http://bind10.isc.org/ticket/3288#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list