BIND 10 #3282: Implement use of DHDP-DDNS configuration parameters in b10-dhcp4

[BIND 10 Development]

#3282: Implement use of DHDP-DDNS configuration parameters in b10-dhcp4
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  enhancement   |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:  task 1.6.1    |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea0.9
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  24 hours      |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  40
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * hours:  0 => 40
 * owner:   => UnAssigned
 * status:  new => reviewing


Comment:

 This ticket modified DHCP4 such that it now uses the following
 configuration values to alter its behavior regarding DHCP-DDNS:

  *  remove-on-renew
  *  override-no-update
  *  override-client-update
  *  replace-client-name
  *  generated-prefix
  *  qualifying-suffix

 During the work on this ticket, it was the team's consensus that the
 following parameter not useful and will be removed under ticket #3294):
  *  always-include-fqdn

 DHCP4 and DHCP6 have virtually identical behavior per RFCs 4702 and 4704,
 so where possible the common logic has been centralized into
 dhcpsrv::D2ClientMgr.

 Changes to dhcp4 were primarily replacing the hard-coded constants
 (FQDN_*) with configuration values or methods supplied via D2ClientMgr.

 Methods were added to D2ClientMgr which work for v4 and v6 to determine
 the server values for FQDN flags and domain names based upon the client
 FQDN and configuration options.  These methods move logic that is common
 to both into a single DDNS specific location.
 A minor change was made to D2ClientConfigParser so that is now supports
 parsing a full
 dhcp-ddns configuration element even if the value of its enable-updates
 entry is false.


 The largest effort though is in unit tests.  The number of permutations of
 clien
 t request data and configuraiton values is relatively high, and testing
 them
 is not entirely trivial.

 Also, corrected a minor issue in setDomainName methods of
 Option4ClientFqdn and Option6ClientFqdn.  They did not update the object's
 domain type if passed an empty domain name.

 !ChangeLog entry:

 {{{
 7xx.    [func]      tmark
     b10-dhcp4 now responds with changes in DDNS behavior based upon
     configuration parameters specified through its dhcp-ddns configuration
     element.  The parameters now active are remove-on-renew,
     override-no-update, override-client-update, replace-client-name,
     generated-prefix, and qualifying-suffix.
     (Trac# 3282, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/3282#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development