BIND 10 #1966: logger formatter does too much in the destructor

BIND 10 Development do-not-reply at isc.org
Thu Jan 30 07:50:03 UTC 2014


#1966: logger formatter does too much in the destructor
--------------------------------+-----------------------------------
            Reporter:  jinmei   |                        Owner:
                Type:  defect   |                       Status:  new
            Priority:  medium   |                    Milestone:
           Component:  logging  |                   Resolution:
            Keywords:           |                 CVSS Scoring:
           Sensitive:  0        |              Defect Severity:  N/A
         Sub-Project:  Core     |  Feature Depending on Ticket:
Estimated Difficulty:  16       |          Add Hours to Ticket:  0
         Total Hours:  0        |                    Internal?:  0
--------------------------------+-----------------------------------

Comment (by muks):

 Replying to [comment:5 jinmei]:
 > All that said...if others are still unhappy about the inconvenience of
 > the alternative, I'd at least suggest making the destructor exception
 > free in the most trivial way:
 >
 > {{{#!cpp
 >     ~Formatter() {
 >         if (logger_) {
 >             try {
 >                 checkExcessPlaceholders(message_, ++nextPlaceholder_);
 >                 logger_->output(severity_, *message_);
 >             } catch (...) {}
 >             delete message_;
 >         }
 >     }
 > }}}

 #3314 has been filed to take care of this for the short-term.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1966#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list