BIND 10 #3358: Default dhcp-ddns config does not have all elements

[BIND 10 Development]

#3358: Default dhcp-ddns config does not have all elements
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  high          |  reviewing
           Component:  dhcp-ddns     |                    Milestone:  DHCP-
            Keywords:                |  Kea0.9
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  8             |              Defect Severity:  N/A
         Total Hours:  11            |  Feature Depending on Ticket:  3373
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  2 => 1
 * owner:  marcin => tmark
 * totalhours:  10 => 11


Comment:

 Reviewed commit 72f017e69f32c908212ff91d8305b32cd9dcff45

 '''src/lib/config/config_data.h'''
 Typos in getFullValue description:
 {{{
     /// If the item referredt toyidentifier is not a map item, then it
 simply
     /// returns the value yielded by getValue() .  If the identifier
     /// refers to a map item, then it returns a merged map of the map
     /// items' defaults and configured values.
 }}}

 I don't understand why the boolean parameter is passed by reference but it
 seems that you just stick to a general convention in this file with
 respect to this (also doxygen comments), so it is ok.

 The spec43.spec must be included in the
 src/lib/config/tests/testdata/Makefile.am. Otherwise you will have issues
 with distcheck....

 Running test....

 There you go:
 {{{
 [ RUN      ] ConfigData.getFullConfigMapLevelDefault
 unknown file: Failure
 C++ exception with description "Error opening
 /home/marcin/devel/bind10/bind10-20140306/_build/../src/lib/config/tests/testdata/spec43.spec:
 No such file or directory" thrown in the test body.
 [  FAILED  ] ConfigData.getFullConfigMapLevelDefault (0 ms)

 }}}

 Once you fix it, please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3358#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development