are these typos in osdep.h?

[HIBBS, BARR (PB)]

Hi, all....

while checking version 3 prior to building a test version I came across what
I think may be some typos in osdep.h.  As none of them effect the
environments I use for development, testing, or production they don't cause
me any problems, but I thought I'd share what I've noticed....

The three areas in question involve the use of raw sockets, DLPI, and
BPF....

from dhcp-3.0b1pl0....

...lines 29-47

#if !defined (USE_SOCKETS) && \
    !defined (USE_SOCKET_SEND) && \
    !defined (USE_SOCKET_RECEIVE) && \
    !defined (USE_RAW_SOCKETS) && \
    !defined (USE_RAW_SEND) && \
    !defined (USE_SOCKET_RECEIVE) && \ <--= shouldn't this be
    !defined (USE_BPF) && \                 USE_RAW_RECEIVE?
    !defined (USE_BPF_SEND) && \
    !defined (USE_BPF_RECEIVE) && \
    !defined (USE_LPF) && \
    !defined (USE_LPF_SEND) && \
    !defined (USE_LPF_RECEIVE) && \
    !defined (USE_NIT) && \
    !defined (USE_NIT_SEND) && \         do we need
    !defined (USE_NIT_RECEIVE) && \      USE_DLPI as well?
    !defined (USR_DLPI_SEND) && \   <--= shouldn't this be
    !defined (USE_DLPI_RECEIVE)          USE_DLPI_SEND?
#  define USE_DEFAULT_NETWORK
#endif


...lines 190-194

#if defined (USE_RAW_RECEIVE) || defined (USE_BPF_SEND) || \
		defined (USE_NIT_RECEIVE) || defined (USE_UPF_RECEIVE) || \
		defined (USE_DLPI_RECEIVE)  || defined (USE_LPF_RECEIVE)
#  define PACKET_DECODING
#endif

shouldn't USE_BPF_SEND in line 190 be USE_BPF_RECEIVE?  I will admit to not
having checked bpf.c to be certain that USE_BPF_SEND doesn't imply
USE_BPF_SEND, but this did attract my attention.


...and finally, lines 269-271 duplicate lines 225-227

#if defined (AF_LINK) && !defined (HAVE_AF_LINK)
# define HAVE_AF_LINK
#endif

while the duplication is harmless, it might confuse future developers....

--Barr