common/dns.c

[Kevin C. Miller]

Hrm. I should have given more background on this. In common/dns.c at line 
729, for example, I would think that:
if (result == YXRRSET || ...
should instead by written:
if (result == ISC_R_YXRRSET || ...

This would be consistent with line 655.

Also, the whole block at 729 should catch NXRRSET, but that falls through 
to 736 (and isc_result_totext(result) returns "no such RRset").

So while cases like line 682 of YXRRSET seem valid (using it as the 
opcode), I would think all the result comparisons should be ISC_R_*

-Kevin

--On Wednesday, September 18, 2002 5:31 PM -0500 Ted Lemon 
<Ted.Lemon at nominum.com> wrote:

> No, that's not correct.   ISC_R_* are result codes used by ISC
> programs.   YXRRSET is a constant defined in the standard.   There may
> be mistakes in the sources, but I just looked, and I don't see any - in
> the case of YXRRSET, it's being used correctly.



---------------------------------------------------
Kevin C. Miller <kcm at cmu.edu>
Network Group
Carnegie Mellon University