ping-timeout patch

[Stephens, Bill {PBSG}]

I'd like to submit a patch for dhcp-3.0.1 to add a dhcpd.conf configuration
parameter called ping-timeout.  

1. What does it do?

This new ping-timeout parameter allows the dhcp administrator to easily
configure how long to have dhcp wait for a ping response before handing out
a lease.  I'm a simpleton, so the patch is fairly straightforward; I even
included the documentation update.

2. How much of a risk to stability does it present?

It's a low risk patch, it just allows the administrator to configure how
long to wait for the ping response.  If no value is set, it defaults to 1
second so that the server will react the same as before the parameter was
available.

3. Is it nicely or badly implemented?

I tried to do the best job, following existing code samples.  It doesn't do
anything fancy, so IMHO it's a fairly clean patch.

4. Does the change apply without anyone needing to hand-edit it?

I am able to apply it against 3.0.1rc11.

5. Is it The Right Thing To Do?

Absolutely.  A one second delay is too short for us.  I am implementing the
ISC DHCP server to support over 600 remote locations, sometimes over slow
56k links.  Periodically I receive problem calls from our help desk that
there are duplicate IP addresses being reported by clients.  Recompiling the
code every time I want to try a longer timeout is unnecessarily cumbersome.
The new parameter makes an administrators life much easier, change the
parameter restart the server and off you go.

6. Is it important?

It is to me, I receive fewer helpdesk calls because I can easily change how
long to wait for the ping to timeout.  The longer ping-timeout has decreased
the number of duplicate IP address problem tickets I receive.

Not one of yours, but I thought I'd throw it in: 
7.  Is it a high priority?

No, not really, it just makes the administrator's job easier by not having
to re-compile every time they want to change the delay.  Hey I'm lazy, with
over 600 subnets to manage anything I can do to make my life easier, I'm all
for.
 
 

Bill Stephens
PepsiCo Business Solutions Group
Bill.Stephens at pbsg.com
972.376.7155      fax: 972.376.6019
 




-- Binary/unsupported file stripped by Ecartis --
-- Type: application/octet-stream
-- File: dhcp-pingtimeout.patch