why is dhclient fqdn options processing & client_dns_update disabled (client->sent_options = 0L) ?

[Jason Vas Dias]

Yes, I've tried it, and it seems to work fine -
I was able to get a lease, and to get the client
to do forward DNS updates (finally!) .
Many thanks,
Jason Vas Dias.
On Mon, 2004-08-16 at 18:22, David W. Hankins wrote:
> On Tue, Aug 17, 2004 at 12:01:00AM +0200, Martin Blapp wrote:
> > > --- dhcp-3.0.1/client/dhclient.c.preserve-sent-options  2004-07-09 20:11:16.000000000 -0400
> > > +++ dhcp-3.0.1/client/dhclient.c        2004-08-16 17:50:41.922782000 -0400
> > > @@ -1945,6 +1945,9 @@
> > >                                     DHO_DHCP_SERVER_IDENTIFIER);
> > >         else
> > >                 oc = (struct option_cache *)0;
> > > +
> > > +       if( client->sent_options != 0L )
> > > +           option_state_dereference (&client -> sent_options, MDL);
> > >
> > >         make_client_options (client, lease, &request, oc,
> > >                              ((client -> state == S_REQUESTING ||
> > > @@ -1968,7 +1971,6 @@
> > >                               (struct data_string *)0,
> > >                               client -> config -> vendor_space_name);
> > >
> > > -       option_state_dereference (&client -> sent_options, MDL);
> > >         if (client -> packet_length < BOOTP_MIN_LEN)
> > >                 client -> packet_length = BOOTP_MIN_LEN;
> > > __END PATCH__
> > 
> > Is this exactly what you will commit David ? Just at line 1949 ?
> i'd like use the word 'probably', because i haven't had the time
> to either compile this or run it here.
> 
> but yes, i think precisely the patch above will appear in 3.0.2
> unless something bad happens in actually trying it out (and btw,
> thanks Jason I think you just volunteered to try it, let me know).
> 
> if that builds and doesn't eat your cat (you can get a lease), then
> i'd say run with it.