lookup_hashed_option()

Anshuman Singh Rawat asr245 at nyu.edu
Fri Jul 23 19:41:16 UTC 2004


> Oh, yes, that sounds right.   The problem is that for DHCPINFORM, 
> the 
> server doesn't look up the client - it just assigns information 
> based 
> on the network to which the client is connected.   You could add 
> the 
> client lookup code, but you'd have to duplicate most of the work 
> that 
> find_lease() does, which would be a pain.   Hm, actually you might 
> be 
> able to just call find_lease(), since find_lease() won't actually 
> _allocate_ a lease.
> 
> There's also a lot to be said for merging the DHCPREQUEST and 
> DHCPINFORM code paths - the reason I didn't do that originally was 
> that 
> I didn't want to pay the cost of the client lookup, but in 
> retrospect I 
> think that was an unnecessary optimization - I think most of the 
> time 
> the server spends handling client requests is writing to the 
> database, 
> which DHCPINFORM would never need to do.

Ok. I called find_lease() from dhcpinform() and then I called execute_statements_in_scope() right after, and that did the job. Total 3-4 lines of code added (which was already there in other routines).

Would you need a diff or something to patch this up in the next release maybe ?

Thanks.
-Anshuman

PS: This list is very silent. Are there any more hackers in here?




More information about the dhcp-hackers mailing list