dhcpleasequery problems - 4.2.2

[Jack Kielsmeier]

We have tested this on an Ubuntu 10.04 server. DHCP 4.2.2 was compiled from
source with no extra flags (all defaults).

We get the same error:
Oct 19 09:49:57 dhcptest dhcpd: Impossible condition at
dhcpleasequery.c:492.
-
Jack Kielsmeier
netINS Systems Administrator
systems at netins.net

-----Original Message-----
From: dhcp-users-bounces+jackkiel=netins.net at lists.isc.org
[mailto:dhcp-users-bounces+jackkiel=netins.net at lists.isc.org] On Behalf Of
Bruce Hudson
Sent: Wednesday, October 19, 2011 8:18 AM
To: dhcp-users at lists.isc.org
Subject: Re: dhcpleasequery problems - 4.2.2

>>      I suspect that the code is NOT there for a reason; at least, not 
>> one that is still valid. The "time_expiry" value it is checking 
>> against "cur_time" is undefined at this point in the code.
> 
> Perhaps the line defining time_expiry (currently after the suspect 
> block of code) needs to be moved before the block of code you commented
out?

    The definition of "time_expiry" after the suspect block is a delta time
value rather than an absolute time. It will always be less than the current
time unless somebody has VERY long leases. I suppose that would make the
"impossible condition" part of the error message correct but I am not sure
what function the check would be serving.

    If you look at the other two variables in this section, "time_renewal"
and "time_rebinding", they are first defined as absolute time values. They
are converted to a delta time value after being compared to the current
time. Perhaps the code used to have something similar for "time_expiry"
before somebody realized "time_expiry" and "lease->ends" were the same thing
and optimized things.
--
Bruce A. Hudson				| Bruce.Hudson at Dal.CA
ITS, Networks and Systems		|
Dalhousie University			|
Halifax, Nova Scotia, Canada		| (902) 494-3405
_______________________________________________
dhcp-users mailing list
dhcp-users at lists.isc.org
https://lists.isc.org/mailman/listinfo/dhcp-users