<div class="gmail_quote">On Wed, Jan 26, 2011 at 11:15 AM, Peter Rathlev <span dir="ltr"><<a href="mailto:peter@rathlev.dk">peter@rathlev.dk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
The problems seems to lie in the fact that the cfile->line1 and<br>
cfile->line2 used in a "buffer swap" style to store current and previous<br>
lines are only char[81]. Enlarging these arrays and adjusting the<br>
counter could move the problem beyond "normal" line lengths.<br></blockquote><div><br></div><div>If you can think of a way to redesign the lexer so that it doesn't have an arbitrary limitation at all, that may be best, but just increasing the buffer sizes sounds reasonable (to me) for maintenance.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Maybe it would be a good idea to update the man-page of dhcpd.conf to<br>
include quoting in the examples (e.g. server/dhcpd.conf.5:1309 in<br>
4.2.0-P2) and point out the problems with unquoted strings.<br></blockquote><div><br></div><div>Not exactly; my memory is that this format is supported because it is identical to BIND 9 config format. This allows using the 'include' statement in bind9 named.conf and dhcpd.conf to read the same key, and you only have to update the key in one place if you change it.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Where would one suggest such a thing? I'm thinking dhcp-users might not<br>
be the right place.<br></blockquote><div><br></div><div>Make a patch against the most recent release from <a href="http://www.isc.org">www.isc.org</a> and mail it to dhcp-bugs@ for bugs or dhcp-suggest@ for features. :)</div>
<div><br></div></div>-- <br><div>David W. Hankins</div><div>SRE</div><div>Google, Inc.</div>