Build issues w/ 4.4.2

[Philip Prindeville]

BTW, this got fixed in 9_11_15 as:

commit 261c84d91d1b4581df9f7f0ec031908299de7726
Author: Mark Andrews <marka at isc.org>
Date:   Thu Dec 19 09:27:44 2019 +1100

    fix variable name in conditional block

diff --git a/lib/isc/stats.c b/lib/isc/stats.c
index 5bce3c1100..a7ab97ce53 100644
--- a/lib/isc/stats.c
+++ b/lib/isc/stats.c
@@ -297,7 +297,7 @@ setcounter(isc_stats_t *stats,
        isc_atomic_store((int32_t *)&stats->counters[counter].lo,
                         (uint32_t)(value & 0xffffffff));
 # else
-       stats->counters[counter] = val;
+       stats->counters[counter] = value;
 # endif
 #endif
 }



So a 4.4.2-P2 release against that version of Bind (well, 9.11.15 or later) should fix it in theory...



> On Nov 29, 2021, at 11:40 AM, Philip Prindeville <philipp_subx at redfish-solutions.com> wrote:
> 
> Also this, despite it being called out ages ago:
> 
> 
> Installing BIND libraries to /home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2-P1/bind.
> stats.c: In function 'setcounter':
> stats.c:300:36: error: 'val' undeclared (first use in this function); did you mean 'value'?
>  300 |         stats->counters[counter] = val;
>      |                                    ^~~
>      |                                    value
> stats.c:300:36: note: each undeclared identifier is reported only once for each function it appears in
> stats.c:286:27: warning: unused parameter 'value' [-Wunused-parameter]
>  286 |            const uint64_t value)
>      |            ~~~~~~~~~~~~~~~^~~~~
> make[5]: *** [Makefile:290: stats.o] Error 1
> 
> 
> Again, it would be trivial to patch this if it weren't coming out of a tarball, but it should be fixed upstream.
> 
> 
> 
>> On Nov 29, 2021, at 11:35 AM, Philip Prindeville <philipp_subx at redfish-solutions.com> wrote:
>> 
>> Still having issues building 4.4.2-P1 with OpenWRT.
>> 
>> Same issue.  How hard is this to fix?
>> 
>> Should we just abandon ISC-DHCP as "no longer supported" for OpenWRT builds?
>> 
>> Our build machinery doesn't support patching files that get unpacked from a tarball as part of the "make" step.
>> 
>> A cleaner fix would be to have a subproject in Bind that built a library that ISC-DHCP could then have a library dependency on...
>> 
>> 
>>> On Jan 29, 2021, at 11:29 AM, Thomas Markwalder <tmark at isc.org> wrote:
>>> 
>>> Bind9 versions after 9.11.14, no longer supply that file. Starting with ISC DHCP 4.4.2, we include a tarball of BIND9 9.11.14 in both the repo and the ISC DHCP  tarball.  The default build configure will use this embedded copy by default.  Bind9 began eliminating these wrapper types with 9.11.15.  9.11.16 gets rid of int and another one that escapes recall at the moment.
>>> 
>>> 4.4.2 is not currently supported for versions beyond 9.11.14.
>>> 
>>> On 1/29/21 1:20 PM, Philip Prindeville wrote:
>>>> I'm seeing the following when building 4.4.2 on x86_64 in OpenWRT:
>>>> 
>>>> ...
>>>> make[5]: Entering directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/common'
>>>> x86_64-openwrt-linux-musl-gcc -DHAVE_CONFIG_H -I. -I../includes  -I.. -DLOCALSTATEDIR='"/var"' -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/usr/include -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/include/fortify -I/home/philipp/lede/staging_dir/toolchain-x86_64_gcc-8.4.0_musl/include   -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -fmacro-prefix-map=/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2=dhcp-4.4.2 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -fcommon   -I../includes -I/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/bind/include -c -o alloc.o alloc.c
>>>> In file included from ../includes/dhcpd.h:91,
>>>>                from alloc.c:29:
>>>> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>>>> #include <isc/boolean.h>
>>>>         ^~~~~~~~~~~~~~~
>>>> compilation terminated.
>>>> Makefile:504: recipe for target 'alloc.o' failed
>>>> make[5]: *** [alloc.o] Error 1
>>>> make[5]: Leaving directory '/home/philipp/lede/build_dir/target-x86_64_musl/isc-dhcp-ipv6/dhcp-4.4.2/common'
>>>> Makefile:563: recipe for target 'all-recursive' failed
>>>> make[4]: *** [all-recursive] Error 1
>>>> 
>>>> 
>>>> Is this a known issue?
>>>> 
>>>> Thanks
>>>> 
>> 
>> _______________________________________________
>> dhcp-workers mailing list
>> dhcp-workers at lists.isc.org
>> https://lists.isc.org/mailman/listinfo/dhcp-workers
> 
> _______________________________________________
> dhcp-workers mailing list
> dhcp-workers at lists.isc.org
> https://lists.isc.org/mailman/listinfo/dhcp-workers