batcher: articles get batched more than once

Yar Tikhiy yar at comp.chem.msu.su
Thu Dec 23 14:41:45 UTC 1999


Hello,

I use the 2.2 branch of INN. Somewhere between the releases
2.2.1 and 2.2.2 backends/batcher.s has been changed, and the
following bug appeared: When a whole batchfile is successfully
processed, its last line is left in it. The article is being
sent again and again if there is no news traffic.
I guess, "Cookie = -1;" is missing somewhere near the end of
the main loop, e.g.

*** batcher.c.orig	Mon Dec 13 16:18:37 1999
--- batcher.c	Thu Dec 23 17:38:26 1999
***************
*** 541,549 ****
  	BytesWritten += BytesInArt;
  	ArtsInCB++;
  	ArtsWritten++;
  
  	if (GotInterrupt) {
- 	    Cookie = -1;
  	    BATCHstatus = BATCHclose(F);
  	    RequeueAndExit(Cookie, line, BytesInArt);
  	}
--- 541,549 ----
  	BytesWritten += BytesInArt;
  	ArtsInCB++;
  	ArtsWritten++;
+ 	Cookie = -1;
  
  	if (GotInterrupt) {
  	    BATCHstatus = BATCHclose(F);
  	    RequeueAndExit(Cookie, line, BytesInArt);
  	}

SY, Yar


More information about the inn-bugs mailing list