innd 2.2.1 crashes on message with bad Distribution: line
Joe Ramey
ramey at hc.ti.com
Thu Nov 18 20:36:19 UTC 1999
Last night my innd 2.2.1 (running on a Sparc server with Solaris 2.6)
dumped core. I found the cause was an article that came in with a bad
Distribution line:
Distribution: ,
I made a quick fix to keep my innd from crashing if another such
article comes in:
*** innd/art.c.ORIG Sun Aug 8 16:56:53 1999
--- innd/art.c Thu Nov 18 14:18:35 1999
***************
*** 2285,2291 ****
/* If we limit what distributions we get, see if we want this one. */
p = HDR(_distribution);
distributions = *p ? CommaSplit(p) : NULL;
! if (distributions) {
DISTparse(distributions, &Data);
if (ME.Distributions
&& !DISTwantany(ME.Distributions, distributions)) {
--- 2285,2291 ----
/* If we limit what distributions we get, see if we want this one. */
p = HDR(_distribution);
distributions = *p ? CommaSplit(p) : NULL;
! if (distributions && distributions[0] && *distributions[0]) {
DISTparse(distributions, &Data);
if (ME.Distributions
&& !DISTwantany(ME.Distributions, distributions)) {
Unfortunately when I tested the patch it worked, so I sent the bad
article to all my downstream feeds, and they crashed. :-(
I think the right fix is probably to reject the article?
Joe
More information about the inn-bugs
mailing list