Bug in innreport, inn221

[David Shrimpton]

Hi All,


I'm writing with a bug report for innreport  version 3.0.0.
that came with inn221.
in case it hasn't been fixed already.




The bug is:

If you set cycle to other than none , eg 7 in innreport.conf
then index.html is missing all the daily reports that are listed
in innreport.db.

I notice that the log cyling code in which the bug resides 
is not present in the version of innreport on the "official" site 
ftp.eerie.fr.  

Assuming it was added by the inn developers, here is a fix if it
is of any interest.


Fix is: 

Add the *-ed  lines in innreport
lines 849 and 866

* $i = 0;
  foreach (sort {$b cmp $a} (keys %data)) {
    if (($CYCLE == 0) || ($i < $CYCLE)) {
      my @list = split /\|/, $data{$_};
      my $str = "<TR><TD ALIGN=LEFT>";
      $str .= "<A HREF=\"$_\">" if -e "$rep/$_";
      $str .= shift @list;
      $str .= "</A>" if -e "$rep/$_";;
      $str .= "</TD>";
      while (@list) {
        $str .= "<TD ALIGN=RIGHT>";
        my $t = shift @list;
        $t =~ s/^\0+//o; # remove garbage, if any.
        $str .= "$t</TD>";
      }
      $str .= "</TR>\n";
      $result .= "$str";
    }
*   $i++;
  }




Regards

-- 
David Shrimpton                       Systems Programmer
Software Infrastructure, Information Technology Services   
University of Qld 4072            shrimpto at its.uq.edu.au
Brisbane Australia                 Phone  61 7 3365 4012