high water mark wrong

Bdale Garbee bdale at col.hp.com
Tue Aug 1 21:35:17 UTC 2000



In the latest BETA snapshots, the nnrpd/commands.c appears to have a problem
with 'list active' high water marks.

If you 'list active' a specific group, the high water mark that is returned
is wrong.  If you query a wildcard, it's correct.  An example from one of
my test servers:

    list active rec.vi*
    215 Newsgroups in form "group high low flags".
    rec.video 0000000168 0000000001 y
    rec.video.cable-tv 0000000070 0000000001 y
    rec.video.desktop 0000001676 0000000001 y
    ...

    list active rec.video
    215 Newsgroups in form "group high low flags".
    rec.video 0000001920 0000000001 y

The 168 returned in the wildcard query is correct, the 1920 is wrong, and
confuses some clients like 'tin' horribly.

My "fix" for this was to clip out the special case in commands.c, and all
seems happy, though probably less efficient.  Hopefully, someone who sees
why this isn't working can come up with a real fix?

Bdale


RCS file: RCS/commands.c,v
retrieving revision 1.1
diff -u -r1.1 commands.c
--- commands.c  2000/08/01 20:54:04     1.1
+++ commands.c  2000/08/01 21:29:05
@@ -1,4 +1,4 @@
-/*  $Id: commands.c,v 1.1 2000/08/01 20:54:04 bdale Exp $
+/*  $Id: commands.c,v 1.2 2000/08/01 21:28:48 bdale Exp $
 **
 **  Miscellaneous commands.
 */
@@ -418,6 +418,8 @@
        if (ac == 3) {
            wildarg = av[2];
 
+#ifdef notdef
+                                       /* seems broken!  - Bdale */
             /* Try to do this the quick way for a single group, but
                currently some overview backends don't support group aliases
                fully, so if the flag is '=' for an alias, fall through to
@@ -427,6 +429,7 @@
                Printf("%s %010d %010d %c\r\n.\r\n", wildarg, hi, lo, flag);
                return;
            }
+#endif /* notdef */
        }
     } else if (caseEQ(p, "active.times"))
        lp = &INFOactivetimes;



More information about the inn-bugs mailing list