INN 2.2: overview data gets truncated
Sven Paulus
sven at karlsruhe.org
Wed Apr 11 12:39:53 UTC 2001
Hi,
a very little bug in INN 2.2.x's nnrpd:
If you issue XOVER commands for the same article multiple times, each time
the overview line you get gets truncated by one character:
200 news.karlsruhe.org InterNetNews NNRP server INN 2.2.3 18-Jul-2000 ready (posting ok).
group ka.test
211 10756 696 12013 ka.test
xover 696
224 data follows
696 ignore uj1i at rz.uni-karlsruhe.de (Georg Mueller) Thu, 18 Jul 1996 01:03:17 GMT <Dups9H.pE at rz.uni-karlsruhe.de> 906 7 Xref: quezovercoatl.argh.sub.de ka.test:696
.
xover 696
224 data follows
696 ignore uj1i at rz.uni-karlsruhe.de (Georg Mueller) Thu, 18 Jul 1996 01:03:17 GMT <Dups9H.pE at rz.uni-karlsruhe.de> 906 7 Xref: quezovercoatl.argh.sub.de ka.test:69
.
xover 696
224 data follows
696 ignore uj1i at rz.uni-karlsruhe.de (Georg Mueller) Thu, 18 Jul 1996 01:03:17 GMT <Dups9H.pE at rz.uni-karlsruhe.de> 906 7 Xref: quezovercoatl.argh.sub.de ka.test:6
.
xover 696
224 data follows
696 ignore uj1i at rz.uni-karlsruhe.de (Georg Mueller) Thu, 18 Jul 1996 01:03:17 GMT <Dups9H.pE at rz.uni-karlsruhe.de> 906 7 Xref: quezovercoatl.argh.sub.de ka.test:
.
This fixes this behaviour (only happens with traditional spool and
overviewmmap: false), maybe it should go to the 2.2 CVS branch for
completeness :-)
--- article.c.keep Wed Apr 11 14:16:14 2001
+++ article.c Wed Apr 11 14:25:34 2001
@@ -1304,8 +1304,11 @@
}
if (OVERarticle == artnum) {
- *linelen = strlen(OVERline) - 1;
- OVERline[*linelen] = '\0';
+ *linelen = strlen(OVERline);
+ if (OVERline[*linelen-1] == '\n') {
+ OVERline[*linelen-1] = '\0';
+ (*linelen)--;
+ }
return OVERline;
}
return NULL;
Sven
More information about the inn-bugs
mailing list