Missing `return' in inn/storage/ov.c

TAKAI Kousuke takai at vlsi.kuee.kyoto-u.ac.jp
Sat Jan 12 12:23:41 UTC 2002



Hello,

I found a small bug in inn-CURRENT: OVhisthasmsgid()
lacks `return' statement.

This seems to have happened to work on x86 (and, possibly,
processors without register-window), but on sparc machines
it makes INN malfunctioning.

Patch for CURRENT-20020111 follows my signature.

I am not in inn-* mailing lists, so please include me to cc.
Sorry for my poor English.

-- 
 TAKAI Kousuke <takai at vlsi.kuee.kyoto-u.ac.jp>
  Dept. of Communications and Computer Engineering,
  Graduate School of Infomatics, Kyoto University, Japan

--- inn-CURRENT-20020111.orig/storage/ov.c	Fri Jan 11 19:01:09 2002
+++ inn-CURRENT-20020111/storage/ov.c	Sat Jan 12 20:44:25 2002
@@ -1184,17 +1184,13 @@
 
 bool OVhisthasmsgid(struct history *h, char *data) {
     char		*p;
-    HASH		key;
-    off_t		offset;
-    int			i, c;
 
     if (!ReadOverviewfmt) {
 	OVfindheaderindex();
     }
     if ((p = OVERGetHeader(data, Messageidindex)) == NULL)
 	return FALSE;
-    if (!HISlookup(h, p, NULL, NULL, NULL, NULL))
-	return FALSE;
+    return HISlookup(h, p, NULL, NULL, NULL, NULL);
 }
 
 bool OVgroupmatch(char *group) {
[end of patch]


More information about the inn-bugs mailing list