More on SITEreader log entires

[Jeffrey M. Vinocur]

On Fri, 8 Mar 2002, William F. Maton wrote:

> #0  0x80756c6 in SITEreader (unused=0x401ea8cc) at site.c:27
> #1  0x806998d in CHANreadloop () at chan.c:1093
> #2  0x806ba94 in main (ac=2, av=0xbffffe94) at innd.c:649
>
> I'm not sure if this helps anyone with finding out why SITEreader()
> getscalledso often.

It doesn't help, unfortunately -- we always loop over it, but the question
is why it appears that there's data to read.


I have two thoughts on what we could do to avoid this problem, at least in
the short term:

- special case in CHANreadloop to never call SITEreader, since we're
  already checking (cp->Type == CTfree)

- modify SITEreader to only log that error once per instance of innd


I can do either of these with no trouble, but they're both a bit ugly so I
won't unless other people think it's a good idea.


-- 
Jeffrey M. Vinocur
jeff at litech.org