[INN] #99: Add a decent command parser to innd
INN
rra at stanford.edu
Thu Dec 25 18:30:43 UTC 2008
#99: Add a decent command parser to innd
------------------------+---------------------------------------------------
Reporter: iulius | Owner: eagle
Type: defect | Status: new
Priority: medium | Milestone: 2.6.0
Component: innd | Version: 2.4.5
Severity: normal | Resolution:
Keywords: compliance |
------------------------+---------------------------------------------------
Comment(by iulius):
In innd, if the connection is determined to need authentication, all
incoming commands other than MODE are handed off to NCauthinfo() rather
than their normal command handlers. NCauthinfo() responds with a 480
reply code to anything other than AUTHINFO USER, AUTHINFO PASS, or QUIT.
Suggested fix: Restructure the command table so that each command also
has a flag indicating whether it requires authentication for peers that
are required to authenticate. (Some commands, like HELP and MODE READER,
should be allowed without authentication.) Then eliminate the special
casing of the state CSgetauth (it may be better to store whether the peer
has authenticated in the channel rather than in the channel state) and the
special handling in NCauthinfo. This should also simplify the code.
--
Ticket URL: <http://inn.eyrie.org/trac/ticket/99#comment:2>
INN <http://www.eyrie.org/~eagle/software/inn/>
InterNetNews
More information about the inn-bugs
mailing list