innreport buglet (and patch) from 2.4.5

Wim Lewis wiml at hhhh.org
Tue Oct 7 06:14:20 UTC 2008


I think there's a minor bug in innreport's config file handling. As I  
understand this piece of code, it's trying to set $IMG_dir from  
$HTML_dir and $IMG_pth, but only if they were both explicitly set.  
But it tests for the existence of 'html_dir' in one place where it  
should be testing 'img_dir'.

--- innreport.orig      Mon Jul 14 23:53:56 2008
+++ innreport   Mon Oct  6 23:03:06 2008
@@ -212,7 +212,7 @@
  $IMG_pth = $ref{'webpath'} if defined $ref{'webpath'};

  $IMG_dir = $HTML_dir . "/" . $IMG_pth
-  if (defined $output{'default'}{'html_dir'} ||
+  if (defined $output{'default'}{'img_dir'} ||
         defined $ref{'w'} || defined $ref{'webpath'})
        &&
        (defined $output{'default'}{'html_dir'} ||



More information about the inn-bugs mailing list