INN commit: trunk/tests (5 files)

INN Commit Russ_Allbery at isc.org
Wed Aug 22 11:51:37 UTC 2007


    Date: Wednesday, August 22, 2007 @ 04:51:37
  Author: iulius
Revision: 7653

Fix the remaining conditional jumps or moves which depend on
uninitialised values.
The test suite is now free from such problems.

Modified:
  trunk/tests/innd/chan-t.c
  trunk/tests/lib/vector-t.c
  trunk/tests/overview/api-t.c
  trunk/tests/overview/overview-t.c
  trunk/tests/overview/xref-t.c

-----------------------+
 innd/chan-t.c         |    2 ++
 lib/vector-t.c        |    2 +-
 overview/api-t.c      |    5 ++++-
 overview/overview-t.c |    2 ++
 overview/xref-t.c     |    3 +++
 5 files changed, 12 insertions(+), 2 deletions(-)

Modified: innd/chan-t.c
===================================================================
--- innd/chan-t.c	2007-08-21 19:27:16 UTC (rev 7652)
+++ innd/chan-t.c	2007-08-22 11:51:37 UTC (rev 7653)
@@ -102,6 +102,8 @@
        .used and .left, we cannot use buffer_append.
        buffer_append(&cp->In, "", 1); */
     memcpy(cp->In.data + cp->In.used, "", 1);
+    cp->In.used++;
+    cp->In.left--;
     ok_string(12, "some output", cp->In.data);
     SCHANwakeup(&Now);
 }

Modified: lib/vector-t.c
===================================================================
--- lib/vector-t.c	2007-08-21 19:27:16 UTC (rev 7652)
+++ lib/vector-t.c	2007-08-22 11:51:37 UTC (rev 7653)
@@ -143,7 +143,7 @@
     vector_free(vector);
     cvector = cvector_split(empty, ' ', NULL);
     ok_int(68, 1, cvector->count);
-    ok_string(69, "", vector->strings[0]);
+    ok_string(69, "", cvector->strings[0]);
     cvector_free(cvector);
 
     vector = vector_split_space("", NULL);

Modified: overview/api-t.c
===================================================================
--- overview/api-t.c	2007-08-21 19:27:16 UTC (rev 7652)
+++ overview/api-t.c	2007-08-22 11:51:37 UTC (rev 7653)
@@ -60,7 +60,8 @@
 
 /* Build a stripped-down innconf struct that contains only those settings that
    the overview backend cares about.  (May still be missing additional bits
-   for ovdb.) */
+   for ovdb.)
+   innconf->icdsynccount defines OVBUFF_SYNC_COUNT. */
 static void
 fake_innconf(void)
 {
@@ -75,7 +76,9 @@
     innconf = xmalloc(sizeof(*innconf));
     innconf->enableoverview = true;
     innconf->groupbaseexpiry = true;
+    innconf->icdsynccount = 10;
     innconf->keepmmappedthreshold = 1024;
+    innconf->nfsreader = false;
     innconf->overcachesize = 20;
     innconf->ovgrouppat = NULL;
     innconf->pathdb = xstrdup("ov-tmp");

Modified: overview/overview-t.c
===================================================================
--- overview/overview-t.c	2007-08-21 19:27:16 UTC (rev 7652)
+++ overview/overview-t.c	2007-08-22 11:51:37 UTC (rev 7653)
@@ -88,7 +88,9 @@
     innconf = xmalloc(sizeof(*innconf));
     innconf->enableoverview = true;
     innconf->groupbaseexpiry = true;
+    innconf->icdsynccount = 10;
     innconf->keepmmappedthreshold = 1024;
+    innconf->nfsreader = false;
     innconf->overcachesize = 20;
     innconf->ovgrouppat = NULL;
     innconf->ovmethod = xstrdup(STRING(OVTYPE));

Modified: overview/xref-t.c
===================================================================
--- overview/xref-t.c	2007-08-21 19:27:16 UTC (rev 7652)
+++ overview/xref-t.c	2007-08-22 11:51:37 UTC (rev 7653)
@@ -25,9 +25,11 @@
 fake_innconf(void)
 {
     innconf = xmalloc(sizeof(*innconf));
+    innconf->articlemmap = false;
     innconf->enableoverview = true;
     innconf->groupbaseexpiry = true;
     innconf->keepmmappedthreshold = 1024;
+    innconf->nfsreader = false;
     innconf->overcachesize = 20;
     innconf->ovgrouppat = NULL;
     innconf->ovmethod = xstrdup("tradindexed");
@@ -39,6 +41,7 @@
     innconf->pathrun = xstrdup("ov-tmp");
     innconf->storeonxref = true;
     innconf->tradindexedmmap = true;
+    innconf->wireformat = false;
 }
 
 /* Initialize the overview database. */



More information about the inn-committers mailing list