INN commit: trunk/nnrpd (group.c)

INN Commit Russ_Allbery at isc.org
Sun Aug 24 11:10:35 UTC 2008


    Date: Sunday, August 24, 2008 @ 04:10:34
  Author: iulius
Revision: 7962

Use 403 instead of 503 if the group disappeared.
Also use the preferred way to indicate an empty group:
  lowmark = highmark + 1.

Modified:
  trunk/nnrpd/group.c

---------+
 group.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Modified: group.c
===================================================================
--- group.c	2008-08-24 09:51:57 UTC (rev 7961)
+++ group.c	2008-08-24 11:10:34 UTC (rev 7962)
@@ -103,7 +103,7 @@
     /* Doing a "group" command? */
     if (strcasecmp(av[0], "group") == 0) {
 	if (count == 0)
-	    Reply("%d 0 0 0 %s\r\n", NNTP_OK_GROUP, group);
+	    Reply("%d 0 1 0 %s\r\n", NNTP_OK_GROUP, group);
 	else {
 	    /* if we're an NFS reader, check the last nfsreaderdelay
 	     * articles in the group to see if they arrived in the
@@ -121,7 +121,7 @@
 		    low = ARThigh - innconf->nfsreaderdelay;
 		handle = OVopensearch(group, low, ARThigh);
 		if (!handle) {
-		    Reply("%d group disappeared\r\n", NNTP_ERR_UNAVAILABLE);
+		    Reply("%d group disappeared\r\n", NNTP_FAIL_ACTION);
 		    free(group);
 		    return;
 		}
@@ -154,7 +154,7 @@
            returns the same data as GROUP does and since we have it all
            available it shouldn't hurt to return the same thing. */
         if (count == 0) {
-            Reply("%d 0 0 0 %s\r\n", NNTP_OK_GROUP, group);
+            Reply("%d 0 1 0 %s\r\n", NNTP_OK_GROUP, group);
             Printf(".\r\n");
         } else if ((handle = OVopensearch(group, ARTlow, ARThigh)) != NULL) {
             Reply("%d %d %lu %lu %s\r\n", NNTP_OK_GROUP, count, ARTlow,



More information about the inn-committers mailing list