INN commit: trunk/nnrpd (commands.c)

INN Commit Russ_Allbery at isc.org
Fri Dec 5 23:29:46 UTC 2008


    Date: Friday, December 5, 2008 @ 15:29:45
  Author: iulius
Revision: 8208

Fix a bug introduced in revision 8061.

When no group is selected and authentication occurs, articles could not
be retrieved by their message-IDs.

Thanks to Fred Senault for having spotted that issue.

Modified:
  trunk/nnrpd/commands.c

------------+
 commands.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Modified: commands.c
===================================================================
--- commands.c	2008-12-02 17:36:30 UTC (rev 8207)
+++ commands.c	2008-12-05 23:29:45 UTC (rev 8208)
@@ -31,14 +31,21 @@
 
 /*
 **  Check after a successful authentication if the currently selected
-**  newsgroup is still readable.  AUTHINFO SASL does not need it because
-**  the NNTP protocol is reset after it.
+**  newsgroup is still readable.  AUTHINFO SASL and STARTTLS do not need
+**  it because the NNTP protocol is reset after it.
+**
+**  Return true if the group must be made invalid.
 */
 static bool
 makeGroupInvalid(void) {
     bool hookpresent = false;
     char *grplist[2];
 
+    /* If no group has been selected yet, it is considered as valid. */
+    if (GRPcur == NULL) {
+        return false;
+    }
+
 #ifdef DO_PYTHON
     hookpresent = PY_use_dynamic;
     if (hookpresent) {




More information about the inn-committers mailing list