INN commit: trunk/nnrpd (sasl.c)

INN Commit Russ_Allbery at isc.org
Tue Dec 30 22:24:37 UTC 2008


    Date: Tuesday, December 30, 2008 @ 14:24:37
  Author: iulius
Revision: 8268

Fix a bug after successful AUTHINFO SASL:  the knowledge acquired
since the beginning of the session was not reset when no security
layer was negotiated during the SASL exchange.

Modified:
  trunk/nnrpd/sasl.c

--------+
 sasl.c |   30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

Modified: sasl.c
===================================================================
--- sasl.c	2008-12-27 16:04:03 UTC (rev 8267)
+++ sasl.c	2008-12-30 22:24:37 UTC (rev 8268)
@@ -302,22 +302,20 @@
 	sasl_maxout =
 	    (*maxoutp == 0 || *maxoutp > NNTP_MAXLEN_COMMAND) ? NNTP_MAXLEN_COMMAND : *maxoutp;
 
-        if (sasl_ssf != 0) {
-            /* Close out any existing article, report group stats.
-             * RFC 4643 requires the reset of any knowledge about the client. */
-            if (GRPcur) {
-                bool boolval;
-                ARTclose();
-                GRPreport();
-                OVctl(OVCACHEFREE, &boolval);
-                free(GRPcur);
-                GRPcur = NULL;
-                if (ARTcount)
-                    syslog(L_NOTICE, "%s exit for AUTHINFO SASL articles %ld groups %ld",
-                           Client.host, ARTcount, GRPcount);
-                GRPcount = 0;
-                PERMgroupmadeinvalid = false;
-            }
+        /* Close out any existing article, report group stats.
+         * RFC 4643 requires the reset of any knowledge about the client. */
+        if (GRPcur) {
+            bool boolval;
+            ARTclose();
+            GRPreport();
+            OVctl(OVCACHEFREE, &boolval);
+            free(GRPcur);
+            GRPcur = NULL;
+            if (ARTcount)
+                syslog(L_NOTICE, "%s exit for AUTHINFO SASL articles %ld groups %ld",
+                       Client.host, ARTcount, GRPcount);
+            GRPcount = 0;
+            PERMgroupmadeinvalid = false;
         }
     } else {
 	/* Failure. */




More information about the inn-committers mailing list