INN commit: branches/2.5 (doc/pod/news.pod innd/nc.c)

[INN Commit]

    Date: Wednesday, December 30, 2009 @ 05:04:53
  Author: iulius
Revision: 8877

Commit 8765 (mandatory AUTHINFO USER for authenticated peers)
will be only in INN 2.6.0 -- not INN 2.5.2.

Modified:
  branches/2.5/doc/pod/news.pod
  branches/2.5/innd/nc.c

------------------+
 doc/pod/news.pod |   16 +++++-----------
 innd/nc.c        |    4 ++++
 2 files changed, 9 insertions(+), 11 deletions(-)

Modified: doc/pod/news.pod
===================================================================
--- doc/pod/news.pod	2009-12-30 13:04:30 UTC (rev 8876)
+++ doc/pod/news.pod	2009-12-30 13:04:53 UTC (rev 8877)
@@ -1,13 +1,5 @@
 =head1 Changes in 2.5.2
 
-Please note that owing to the implementation of S<RFC 4643> (AUTHINFO USER/PASS)
-in B<innd>, if remote peers have to authenticate in order to feed articles,
-they now have to send a username (which was previously wrongly optional), before
-sending their password.  The mandatory username, though unused by B<innd>, can be
-whatever the remote peer wishes.  In previous versions of INN, B<inncheck> was
-already complaining when F<passwd.nntp> contained an empty username associated
-with a password.
-
 =over 2
 
 =item *
@@ -17,7 +9,9 @@
 now recognizes the CAPABILITIES command.  Notwithstanding these standards,
 three commands (IHAVE, CHECK and TAKETHIS) will continue, for interoperability
 reasons, to return a reject code (respectively C<435>, C<438> and C<439>) when
-the command contains a syntax error (which normally leads to C<501>).
+the command contains a syntax error (which normally leads to C<501>).  Besides,
+the mandatory username for authenticated peers will only be enforced by
+S<INN 2.6.0>.
 
 Major improvements are:
 
@@ -47,8 +41,8 @@
 
 =item *
 
-When using HEAD or STAT with an article number or a range, 412 (no group
-selected) is now returned instead of 501 (syntax error).
+When using HEAD or STAT with an article number or a range, C<412> (no
+group selected) is now returned instead of C<501> (syntax error).
 
 =back
 

Modified: innd/nc.c
===================================================================
--- innd/nc.c	2009-12-30 13:04:30 UTC (rev 8876)
+++ innd/nc.c	2009-12-30 13:04:53 UTC (rev 8877)
@@ -486,6 +486,9 @@
     }
 
     /* AUTHINFO PASS cannot be sent before AUTHINFO USER. */
+    /* Enforced only in INN 2.6.0, for backwards compatibility.
+     * [INN 2.5.2 implements RFC 3977 + RFC 4643 + RFC 4644 in innd.] */
+    /*
     if (!cp->HasSentUsername) {
         xasprintf(&buff, "%d Authentication commands issued out of sequence",
                   NNTP_FAIL_AUTHINFO_REJECT);
@@ -493,6 +496,7 @@
         free(buff);
         return;
     }
+    */
 
     /* Got the password -- is it okay? */
     if (!RCauthorized(cp, cp->av[2])) {