INN commit: trunk/frontends (mailpost.in)

[INN Commit]

    Date: Monday, May 4, 2009 @ 12:57:12
  Author: iulius
Revision: 8445

Do not use "\n" in syslog() calls.  And always log an error
message, even though we are not running in debug mode.

Modified:
  trunk/frontends/mailpost.in

-------------+
 mailpost.in |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Modified: mailpost.in
===================================================================
--- mailpost.in	2009-05-04 19:44:55 UTC (rev 8444)
+++ mailpost.in	2009-05-04 19:57:12 UTC (rev 8445)
@@ -303,7 +303,7 @@
     $msg = "can't open temp file ($tmpfile): $!" ;
     $tmpfile = undef ;
     if ($use_syslog) {
-        syslog("err", "$msg\n") unless $debugging || -t STDERR;
+        syslog("err", "$msg") unless $debugging || -t STDERR;
     }
     open(TMPFILE, "|" . sprintf ($Sendmail, $Maintainer)) ||
 	die "die(no tmpfile): sendmail: $!\n" ;
@@ -385,7 +385,7 @@
 
 ## crosspost -c
   $newsgroups = &append_newsgroups($DATABASE{$message_id}, $newsgroups) ;
-  syslog("err", "crosspost $newsgroups\n") if $debugging && $use_syslog;
+  syslog("err", "crosspost $newsgroups") if $debugging && $use_syslog;
 }
 
 #$DATABASE{$message_id} = sprintf "%d.%s", time, 'mailpost' ;
@@ -425,7 +425,7 @@
   umask($umask_bak);
 
   my $dup = undef ;
-  syslog("err", "check   " . $DATABASE{$message_id} . " :  $newsgroups\n") if $debugging && $use_syslog;
+  syslog("err", "check   " . $DATABASE{$message_id} . " :  $newsgroups") if $debugging && $use_syslog;
   $dup = 1 if ($DATABASE{$message_id} ne $newsgroups) ;
 
   dbmclose(%DATABASE) || mailArtAndDie ("can't dbmclose $Database: $!") ;
@@ -434,7 +434,7 @@
   close LOCKFILE ;
 
   if (defined($dup)) {
-    syslog("err", "mismatch $newsgroups\n") if $debugging && $use_syslog;
+    syslog("err", "mismatch $newsgroups") if $debugging && $use_syslog;
     exit(1);
   }
 
@@ -492,7 +492,7 @@
 sub mailArtAndDie {
     my ($msg) = @_ ;
     
-    syslog("err", "$msg\n") if $debugging && $use_syslog;
+    syslog("err", "$msg") if $use_syslog;
     print STDERR $msg,"\n" if -t STDERR ;
     
     open(SENDMAIL, "|" . sprintf ($Sendmail,$Maintainer)) ||