INN commit: branches/2.5/nnrpd (sasl.c)

[INN Commit]

    Date: Monday, February 8, 2010 @ 12:53:13
  Author: iulius
Revision: 8958

Better explanation of why SASL_CONTINUE must be changed
to SASL_BADPROT.  Approved by Ken.

Modified:
  branches/2.5/nnrpd/sasl.c

--------+
 sasl.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Modified: sasl.c
===================================================================
--- sasl.c	2010-02-08 20:52:50 UTC (rev 8957)
+++ sasl.c	2010-02-08 20:53:13 UTC (rev 8958)
@@ -172,8 +172,9 @@
             clientinlen = 0;
 	} else {
 	    /* Decode the response.  On error, SASL_CONTINUE should not be
-             * given.  Use SASL_BADPROT instead, in order to indicate
-             * a base64-encoding error. */
+             * given because we know for sure that we have already received
+             * the whole challenge/response.  Use SASL_BADPROT instead,
+             * in order to indicate a base64-encoding error. */
             r1 = sasl_decode64(clientin, strlen(clientin),
                                base64, BASE64_BUF_SIZE, &clientinlen);
             clientin = base64;
@@ -255,8 +256,9 @@
             clientinlen = 0;
         } else {
             /* Decode the response.  On error, SASL_CONTINUE should not be
-             * given.  Use SASL_BADPROT instead, in order to indicate
-             * a base64-encoding error. */
+             * given because we know for sure that we have already received
+             * the whole challenge/response.  Use SASL_BADPROT instead,
+             * in order to indicate a base64-encoding error. */
             r1 = sasl_decode64(clientin, clientinlen,
                                base64, BASE64_BUF_SIZE, &clientinlen);
             clientin = base64;