INN commit: trunk/nnrpd (post.c)

INN Commit rra at isc.org
Sat Jan 16 16:30:40 UTC 2010


    Date: Saturday, January 16, 2010 @ 08:30:39
  Author: iulius
Revision: 8887

No longer check for Comments: and Original-Sender: in nnrpd.
Otherwise, multiple headers for them were rejected by nnrpd,
which violated RFCs 5536 and 5537.

Only CURRENT was affected.

Modified:
  trunk/nnrpd/post.c

--------+
 post.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Modified: post.c
===================================================================
--- post.c	2010-01-16 16:07:19 UTC (rev 8886)
+++ post.c	2010-01-16 16:30:39 UTC (rev 8887)
@@ -70,12 +70,12 @@
     {   "Bcc",                  true,   HTstd,  0,    NULL,    NULL, 0 },
     {   "To",                   true,   HTstd,  0,    NULL,    NULL, 0 },
     {   "Archived-At",          true,   HTstd,  0,    NULL,    NULL, 0 },
-    {   "Comments",             true,   HTstd,  0,    NULL,    NULL, 0 },
-    {   "Original-Sender",      true,   HTstd,  0,    NULL,    NULL, 0 },
     {   "Also-Control",         false,  HTobs,  0,    NULL,    NULL, 0 },
     {   "Article-Names",        false,  HTobs,  0,    NULL,    NULL, 0 },
     {   "Article-Updates",      false,  HTobs,  0,    NULL,    NULL, 0 },
     {   "See-Also",             false,  HTobs,  0,    NULL,    NULL, 0 },
+/* The Comments: and Original-Sender: header fields can appear more than once
+ * in the headers of an article.  Consequently, we MUST NOT put them here. */
 };
 
 HEADER *EndOfTable = ARRAY_END(Table);
@@ -210,8 +210,8 @@
 		    return NULL;
 		}
 		hp->Value = &p[hp->Size + 1];
-		/* '\r\n,' is replaced with '\n', and unnecessary to consider
-		 *  '\r'. */
+		/* '\r\n' is replaced with '\n', and unnecessary to consider
+		 * '\r'. */
 		for (q = &p[hp->Size + 1]; ISWHITE(*q) || *q == '\n'; q++)
 		    continue;
 		hp->Body = q;
@@ -631,7 +631,7 @@
     if ((address = GetModeratorAddress(NULL, NULL, group, PERMaccessconf->moderatormailer)) == NULL) {
 	snprintf(Error, sizeof(Error), "No mailing address for \"%s\" -- %s",
                  group, "ask your news administrator to fix this");
-	free(group);  
+	free(group);
 	return Error;
     }
     free(group);
@@ -1034,7 +1034,7 @@
 
     if ((error = ValidNewsgroups(HDR(HDR__NEWSGROUPS), &modgroup)) != NULL)
 	return error;
-    
+
     strlcpy(frombuf, HDR(HDR__FROM), sizeof(frombuf));
     for (i = 0, p = frombuf;p < frombuf + sizeof(frombuf);)
 	if ((p = strchr(p, '\n')) == NULL)




More information about the inn-committers mailing list