INN commit: branches/2.5 (doc/pod/news.pod nnrpd/commands.c)

[INN Commit]

    Date: Friday, January 22, 2010 @ 14:54:53
  Author: iulius
Revision: 8915

When an unauthenticated user tried to post an article, nnrpd replied 440
(posting not allowed) instead of the right 480 (authentication required)
when the user might be able to post after authentication.

Thanks to Daniel Weber for the bug report.

Modified:
  branches/2.5/doc/pod/news.pod
  branches/2.5/nnrpd/commands.c

------------------+
 doc/pod/news.pod |   10 +++++++++-
 nnrpd/commands.c |    4 +++-
 2 files changed, 12 insertions(+), 2 deletions(-)

Modified: doc/pod/news.pod
===================================================================
--- doc/pod/news.pod	2010-01-22 22:48:04 UTC (rev 8914)
+++ doc/pod/news.pod	2010-01-22 22:54:53 UTC (rev 8915)
@@ -149,13 +149,21 @@
 
 =item *
 
+When an unauthenticated user tried to post an article, B<nnrpd> replied
+C<440> (posting not allowed) instead of the right C<480> (authentication
+required) when the user might be able to post after authentication.
+Thanks to Daniel Weber for the bug report.
+
+=item *
+
 Fixed a bug in both B<innd> and B<nnrpd> answers to LIST commands which
 did not check for a valid dot-stuffed output.
 
 =item *
 
 Fixed a bug to control-only feeds:  junked non-control articles were being
-fed down control-only feeds.  Thanks to Andrew Gierth for the patch.
+fed down control-only feeds.  Besides, poisoned control groups were not
+properly handled.  Thanks to Andrew Gierth for the patch.
 
 =item *
 

Modified: nnrpd/commands.c
===================================================================
--- nnrpd/commands.c	2010-01-22 22:48:04 UTC (rev 8914)
+++ nnrpd/commands.c	2010-01-22 22:54:53 UTC (rev 8915)
@@ -616,7 +616,9 @@
     }
     if (!ihave && !PERMcanpost) {
 	syslog(L_NOTICE, "%s noperm post without permission", Client.host);
-	Reply("%d Posting not allowed\r\n", NNTP_FAIL_POST_AUTH);
+        Reply("%d Posting not allowed\r\n",
+              PERMcanauthenticate && PERMcanpostgreeting ?
+              NNTP_FAIL_AUTH_NEEDED : NNTP_FAIL_POST_AUTH);
 	return;
     }