INN commit: branches/2.5/innd (art.c)

INN Commit rra at isc.org
Fri Jan 22 23:37:38 UTC 2010


    Date: Friday, January 22, 2010 @ 15:37:37
  Author: iulius
Revision: 8925

Though it currently does no harm to use ngp here, it is
better to have another variable (in case the logic of the
code changes in the future, ngp may be used for another
purpose and should not be initialized here).

See commit [8920].

Modified:
  branches/2.5/innd/art.c

-------+
 art.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Modified: art.c
===================================================================
--- art.c	2010-01-22 23:35:56 UTC (rev 8924)
+++ art.c	2010-01-22 23:37:37 UTC (rev 8925)
@@ -1924,6 +1924,7 @@
   int		i, j, *isp, hopcount, oerrno, canpost;
   size_t        n;
   NEWSGROUP	*ngp, **ngptr;
+  NEWSGROUP     *ngpjunk;
   SITE		*sp;
   ARTDATA	*data = &cp->Data;
   HDRCONTENT	*hc = data->HdrContent;
@@ -2237,9 +2238,9 @@
       } else if (innconf->wanttrash && !innconf->verifygroups) {
         /* Don't set Accepted in this case, because we may still end
          * up filing the article in the junk group. */
-        for (ngp = NGfind(ARTjnk), sp = Sites, i = nSites; --i >= 0; sp++) {
+        for (ngpjunk = NGfind(ARTjnk), sp = Sites, i = nSites; --i >= 0; sp++) {
             if (sp->Name != NULL && sp->FeedTrash && SITEwantsgroup(sp, *groups)) {
-                SITEmark(sp, ngp);
+                SITEmark(sp, ngpjunk);
             }
         }
         NonExist = true;




More information about the inn-committers mailing list